Skip to content

feat: add a revocations test for a second scope #958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
travis wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: add a revocations test for a second scope #958

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ec2e2e
feat: add a revocations test for a second scope
travis Oct 6, 2023
a0ae786
fix: tpyo
travis Oct 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 28 additions & 9 deletions packages/upload-api/test/storage/revocations-storage-tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,30 +8,49 @@ import { createSampleDelegation } from '../../src/utils/ucan.js'
export const test = {
'can add and retrieve revocations': async (assert, context) => {
const storage = context.revocationsStorage
const badRevocation = await createSampleDelegation()
const proofRevocation = await createSampleDelegation()
const badDelegation = await createSampleDelegation()
const scopeDelegation = await createSampleDelegation()
const invocationCID = await randomCID()

const { ok: revoked } = await storage.getAll([proofRevocation.cid, badRevocation.cid])
const { ok: revoked } = await storage.getAll([scopeDelegation.cid, badDelegation.cid])
assert.deepEqual(revoked, [])

await storage.addAll([{ revoke: badRevocation.cid, scope: proofRevocation.cid, cause: invocationCID }])
await storage.addAll([{
revoke: badDelegation.cid,
scope: scopeDelegation.cid,
cause: invocationCID
}])

// it should return revocations that have been recorded
const { ok: revocationsToMeta } = await storage.getAll([badRevocation.cid])
const { ok: revocationsToMeta } = await storage.getAll([badDelegation.cid])
assert.deepEqual(revocationsToMeta, [
{ revoke: badRevocation.cid, scope: proofRevocation.cid, cause: invocationCID }
{ revoke: badDelegation.cid, scope: scopeDelegation.cid, cause: invocationCID }
])

// it should not return revocations that have not been recorded
const { ok: noRevocations } = await storage.getAll([proofRevocation.cid])
const { ok: noRevocations } = await storage.getAll([scopeDelegation.cid])
assert.deepEqual(noRevocations, [])

// it should return revocations that have been recorded
const { ok: someRevocations } = await storage.getAll([badRevocation.cid, proofRevocation.cid])
const { ok: someRevocations } = await storage.getAll([badDelegation.cid, scopeDelegation.cid])
assert.deepEqual(someRevocations, [
{ revoke: badRevocation.cid, scope: proofRevocation.cid, cause: invocationCID }
{ revoke: badDelegation.cid, scope: scopeDelegation.cid, cause: invocationCID }
])

// if we revoke from an alternate scope
const alternateScopeDelegation = await createSampleDelegation()
const secondInvocationCID = await randomCID()
await storage.addAll([{
revoke: badDelegation.cid,
scope: alternateScopeDelegation.cid,
cause: secondInvocationCID
}])

// it should return both revocations
const { ok: moreRevocations } = await storage.getAll([badDelegation.cid])
assert.deepEqual(moreRevocations, [
{ revoke: badDelegation.cid, scope: scopeDelegation.cid, cause: invocationCID },
{ revoke: badDelegation.cid, scope: alternateScopeDelegation.cid, cause: secondInvocationCID }
])
}
}