chore: remove store protocol references - #651
Closed
travis wants to merge 11 commits into
Closed
Conversation
travis
marked this pull request as draft
January 30, 2026 17:49
travis
had a problem deploying
to
preview-651/merge
January 30, 2026 17:49 — with 
GitHub Actions
Failure
GitHub Actions
Failure
fforbeck
force-pushed
the
feat/remove-store-protocol-v2
branch
from
March 13, 2026 13:03
4546e46 to
1ec0f51
Compare
fforbeck
had a problem deploying
to
preview-651/merge
March 13, 2026 13:04 — with
GitHub Actions
Failure
GitHub Actions
Failure
Replace deprecated store/* capability references with modern space/blob/* equivalents in code comments and documentation. Also clarify that upload/add can skip space/blob/add when shards already exist in the same space.
fforbeck
had a problem deploying
to
preview-651/merge
March 13, 2026 13:22 — with
GitHub Actions
Failure
GitHub Actions
Failure
Update remaining test files that used store/* wildcard capability to use the modern space/blob/* equivalent.
fforbeck
had a problem deploying
to
preview-651/merge
March 13, 2026 13:29 — with
GitHub Actions
Failure
GitHub Actions
Failure
- Remove store/* from default shareSpace abilities - Remove StoreAdd, StoreList, StoreRemove type exports
fforbeck
temporarily deployed
to
preview-651/merge
March 13, 2026 13:45 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
fforbeck
marked this pull request as ready for review
March 13, 2026 13:47
Contributor
Website preview 🔗✨ |
fforbeck
changed the title
fforbeck
requested review from
BravoNatalie,
Peeja and
alanshaw
and removed request for
a team and
alanshaw
March 13, 2026 14:29
alanshaw
approved these changes
Mar 16, 2026
|
|
||
| // If there was no Blob, try the Store protocol. | ||
| try { | ||
| return await client.capability.store.get(shard) |
Member
There was a problem hiding this comment.
Have store items been migrated to the blob registry?
Member
There was a problem hiding this comment.
If folks have stored data with the store protocol then it'll be in the store dynamo table. Getting or listing i.e. store/get/store/list usually reads from that table. Also store/remove will normally allow folks to remove the data. So if I understand correctly folks will not be able to get/list or remove their stored items but they will still be charged for data storage? I would say that's a blocker yes...
BravoNatalie
approved these changes
Mar 16, 2026
BravoNatalie
requested changes
Mar 16, 2026
| } | ||
|
|
||
| /** | ||
| * @template {API.ParsedCapability<"store/add"|"store/get"|"store/remove", API.URI<'did:'>, {link?: API.Link<unknown, number, number, 0|1>}>} T |
Contributor
There was a problem hiding this comment.
remove store/add and store/remove type ref
Member
|
I'm closing this PR because we will remove only the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes backwards compatibility with legacy capabilities (store/*)
After this is merged, our UCAN servers may throw errors for delegations including these capabilities.