fix: add staging plans to plan definition list - #640
Merged
Conversation
otherwise we see errors on the plan page in staging
travis
temporarily deployed
to
preview-640/merge
January 23, 2026 17:28 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
travis
temporarily deployed
to
preview-640/merge
January 23, 2026 17:30 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Contributor
Website preview 🔗✨ |
volmedo
approved these changes
Jan 23, 2026
Comment on lines
+203
to
+204
| console.log("PLAN", plan) | ||
| console.log("IS PLAN LOADING", isPlanLoading) |
Contributor
There was a problem hiding this comment.
maybe you want to remove these before merging?
Contributor
|
also, does the logic showing these need to be adjusted to filter plans depending on the environment? It wouldn't be great to show staging plans in prod. |
BravoNatalie
approved these changes
Jan 23, 2026
Contributor
Author
ah, this isn't used to select plans, just to find a human readable name for them - if people have staging plans in production they'll see this but that's a good thing - that would be a very weird state of affairs we'd need to fix manually |
travis
pushed a commit
that referenced
this pull request
Jan 26, 2026
🤖 I have created a release *beep* *boop* --- ## [2.20.0](console-v2.19.2...console-v2.20.0) (2026-01-23) ### Features * add egress reporting to account/usage/get ([#611](#611)) ([df39e6f](df39e6f)) ### Fixes * add staging plans to plan definition list ([#640](#640)) ([7774e51](7774e51)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
otherwise we see errors on the plan page in staging