fix: allow session authorities as principals - #384
Closed
alanshaw wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #369 we introduced a change where authorities other than the service itself can issue attestations allowing validation to pass.
This was done by configuring the service with a delegation that authorizes the other authority to make attestations on it's behalf.
This works fine when the UCAN validation is being done by the authority the UCAN is being validated against, since the authority can just issue a delegation to the other authority. However in the case where the UCAN validation is being done by some other agent, it is not possible to provide a delegation and hence not possible to validate with alternate attestation authorities.
The storacha bluesky app validates UCANs against the storacha service authority (
did:web:up.storacha.network) but because the bluesky service is not the storacha service it is unable to provide a delegation that authorizesdid:web:web3.storageto make attestations on it's behalf. Hence a different approach is needed.