feat: configure replication count - #400
Merged
Merged
Conversation
frrist
approved these changes
Apr 13, 2026
|
|
||
| import "fmt" | ||
|
|
||
| type PreparationConfig struct { |
Member
There was a problem hiding this comment.
I'm not keen on the naming of this, as a user reading the config Preparation will throw me off. I think I'd prefer Upload or something along those lines, parallelism will likely eventually be included there too, later maybe even block_size and/or dag_type (balanced vs trickle). But this isn't a blocking comment, up to you.
Member
Author
There was a problem hiding this comment.
Yes same. I will change to "upload".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows the replication count to be configured. It's a hidden flag, since we don't really want users to change this, it's mostly for testing where we might want/need to reduce it to 1.
Aside, we should probably allow a couple of the other preparation flags to be configured in TOML also.