WIP: Validator - #5
Closed
hannahhoward wants to merge 1 commit into
Closed
Conversation
add all errors from JS Ucanto
alanshaw
reviewed
Aug 12, 2024
| type Version = string | ||
|
|
||
| // UTCUnixTimestamp is a timestamp in seconds since the Unix epoch. | ||
| // UTCUnixTimestamp is a timestamp in milliseconds since the Unix epoch. |
Member
There was a problem hiding this comment.
In UCAN it is seconds: https://github.com/ucan-wg/spec#payload
Member
|
Closing as this work was merged into #13 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goals
This captures work done so far on the validator, which all of the errors (surprsingly a lot of work to encode)