Feat/engine fix - #78
Open
sudo-owen wants to merge 36 commits into
Open
Conversation
# Conflicts: # drool/imgs/attacks/attack_spritesheet.json # drool/imgs/attacks/attack_spritesheet.png # drool/imgs/attacks/throw_pebble.gif # drool/imgs/attacks/throw_pebble.png # drool/imgs/attacks/wither_away.gif # drool/imgs/attacks/wither_away.png # processing/generateMonsTypeScript.py
Its only importer is its own Foundry test, so transpiling it ships dead code into munch's production sim mirror. Same rationale as the other skipFiles entries. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
…leton Library `internal constant`s emit as `static readonly`, but a qualified cross-file reference (Lib.CONST) went through the module singleton like library functions do — instance access to a static member, which TS rejects (TS2576). Track per-contract constants in the registry and emit class-qualified access, pulling the class into the import alongside the singleton. Surfaced by the new resolver/command libs (MoveCommandLib.OP_ATTACK, EffectCommandLib.OP_CLEAR_STATUS) and StatBoostLib.ACC_DISABLED_BIT. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Yul `x.slot` emitted `this._getStorageKey(x)`, a helper that was never defined in the runtime. Engine happens to define its own unrelated `_getStorageKey(bytes32)`, so the call silently bound to that and passed a struct where a battleKey was expected — JSON.stringify then crashed on the struct's BigInt fields. Latent until now: the only prior `.slot` sites assigned to an unused variable. The branch's packed EffectInstance header reads and writes through it for real. Implement `_yulSlotKeyOf` in the runtime, keyed by an identity symbol so a struct keys the same whether or not a capture observer has proxied it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inlines more of the engine logic to lead to lower gas during most happy paths
Adds a few more real-world battle replay gas measurements.