Skip to content

Prevent downgrade of thanos receive PVC to 1Gi in jenkins e2e#2558

Open
dbuchanaRH wants to merge 1 commit into
stolostron:mainfrom
dbuchanaRH:qe-keep-10Gi-thanos-receive
Open

Prevent downgrade of thanos receive PVC to 1Gi in jenkins e2e#2558
dbuchanaRH wants to merge 1 commit into
stolostron:mainfrom
dbuchanaRH:qe-keep-10Gi-thanos-receive

Conversation

@dbuchanaRH

@dbuchanaRH dbuchanaRH commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

e2e tests are deployed with thanos receive storage size at 10Gi. In jenkins QE regressions the test RHACM4K-43019 can run which downgrades the PVC size for thanos receive to 1Gi. If the test suite was running for an extended period of time this will push the thanos receive pods into an error state.

As mentioned in #2257 increasing the PV storage will delay the problem for now. There may come a need for another solution.

After these changes thanos receive storage size should stay at 10Gi through the duration of the e2e suite. receiveStorageSize is not changed for unit tests or for kind e2e tests i.e.

/examples/mco/e2e/v1beta2/custom-certs-kind/observability.yaml

Summary by CodeRabbit

  • Bug Fixes
    • Increased the configured storage size for the observability receive component from 1Gi to 10Gi in example configurations.
    • Updated both initial and advanced setup examples so they reflect the larger storage setting consistently.

Signed-off-by: Daniel Buchanan <dbuchana@redhat.com>
@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 54e4dd8a-0a83-4668-89e0-61e57d086d27

📥 Commits

Reviewing files that changed from the base of the PR and between 7f469b7 and 31d10ad.

📒 Files selected for processing (4)
  • examples/updatemcocr/advancedmcoconfig/custom-certs/v1beta2-observability-custom-mco.yaml
  • examples/updatemcocr/advancedmcoconfig/v1beta2-observability-custom-mco.yaml
  • examples/updatemcocr/initialmcoconfig/custom-certs/v1beta2-observability-initial-mco.yaml
  • examples/updatemcocr/initialmcoconfig/v1beta2-observability-initial-mco.yaml

📝 Walkthrough

Walkthrough

This change updates the receiveStorageSize field from 1Gi to 10Gi across four example MultiClusterObservability YAML manifests in the advanced and initial mco config example directories, including their custom-certs variants.

Changes

Example config storage size updates

Layer / File(s) Summary
Bump receiveStorageSize to 10Gi
examples/updatemcocr/advancedmcoconfig/v1beta2-observability-custom-mco.yaml, examples/updatemcocr/advancedmcoconfig/custom-certs/v1beta2-observability-custom-mco.yaml, examples/updatemcocr/initialmcoconfig/v1beta2-observability-initial-mco.yaml, examples/updatemcocr/initialmcoconfig/custom-certs/v1beta2-observability-initial-mco.yaml
Each manifest's receiveStorageSize value is increased from 1Gi to 10Gi in storageConfig/retentionConfig sections.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Storage sizing bumped fourfold across the fleet of example manifests — like swapping a compact spare tire for a proper one on all four corners at once. Clean, consistent, and no logic to untangle here. Ship it! ✅🔍

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: keeping Thanos receive PVC storage at 10Gi for Jenkins e2e instead of 1Gi.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Jul 8, 2026

Copy link
Copy Markdown

@dbuchanaRH: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/test-e2e 31d10ad link true /test test-e2e

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@thibaultmg thibaultmg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci

openshift-ci Bot commented Jul 9, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dbuchanaRH, thibaultmg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [dbuchanaRH,thibaultmg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants