Update builder.h - #3
Open
curtis-sun wants to merge 1 commit into
Open
Conversation
1. In function "Finalize", if range and num_bins_ are both power of 2, shift_ shoule plus 1 to adapt to num_bins. 2. In function "TransformIntoRadixTable", tree_.front().second[max_prefix+1] is not assigned.
Owner
|
Hi, Curtis! First, thanks for patch! I'll take a closer look on week-end. Until then, could you please fix the typos in the first subcomment? I mean this part: "shift_ shoule plus 1 to adapt to num_bins" -- this way we avoid any confusion of what's meant. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.