chore(docs-deps): refresh lockfile to clear both critical advisories - #342
Merged
Conversation
This was referenced Aug 29, 2026
Closed
Single `npm audit fix --package-lock-only` pass on the docs site. package.json is untouched -- no declared range changes, only the resolved tree. Regenerated against current main, which now carries the merged dependabot bumps (#347, #346, #332, #326, #314, #352, #351, #349, #348). Those bumps did not reach either critical, and dependabot never proposed a fix for websocket-driver at all. before after critical 2 0 high 27 18 moderate 14 8 low 5 0 total 48 26 Both criticals cleared: - shell-quote 1.8.3 -> 1.10.0 (CVE-2026-9277) - websocket-driver 0.7.4 -> 0.7.5 (CVE-2026-54466) Also lodash 4.17.23 -> 4.18.1 and node-forge dropped from the tree. The remaining 26 sit inside the Docusaurus dependency tree -- image-size, serialize-javascript, and the webpack-dev-server -> sockjs -> uuid chain. Most report no non-breaking fix and would need a Docusaurus major upgrade. The dev-server chain affects `docusaurus start`, not `docusaurus build`. `npm audit fix --force` was deliberately not used -- it would churn the Docusaurus major version and risk the docs build, for issues that are dev-time only.
glennko
force-pushed
the
chore/docs-deps-audit-refresh
branch
from
September 3, 2026 03:49
3b9736f to
482f23f
Compare
This was referenced Sep 3, 2026
glennko
added a commit
that referenced
this pull request
Sep 3, 2026
) There was no .github/dependabot.yml, so Dependabot ran on defaults and opened one PR per package against docs/package-lock.json. Twelve such PRs accumulated; they conflicted with each other and with hand-written lockfile work (#342), and each merge forced the rest to rebase. Three were already redundant by the time they were reviewed. Group all docs npm minor/patch bumps into a single weekly PR so the lockfile is only rewritten once per cycle, and cap concurrent PRs at 3. Majors stay ungrouped so they still get individual review. Also groups github-actions bumps, which are low volume. Note the docs site is `private: true` and never published, so these are build-time dependencies only. Co-authored-by: Glenn Ko <glennko@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Single
npm audit fix --package-lock-onlypass on the docs site.package.jsonis untouched — no declared range changes, only the resolved tree.Both criticals cleared:
shell-quote1.8.3 → 1.10.0 (CVE-2026-9277)websocket-driver0.7.4 → 0.7.5 (CVE-2026-54466)Neither had an open PR — dependabot never proposed a fix for either.
Supersedes the open docs dependabot PRs
Every one targeted a version that is no longer sufficient:
What remains
The 24 remaining sit inside the Docusaurus dependency tree —
image-size,serialize-javascript, and thewebpack-dev-server→sockjs→uuidchain. Most report no non-breaking fix and would need a Docusaurus major upgrade. The dev-server chain affectsdocusaurus start, notdocusaurus build.npm audit fix --forcewas deliberately not used — it would churn the Docusaurus major version and risk the docs build, for issues that are dev-time only.Scope note
All 69 GitHub advisories for this repo are in
docs/package-lock.json. The docs site isprivate: trueand never published, so none of this ships to users of the Python package.Checklist
npm cithennpm run build: both bundles compile, static files generated