Adding support for non-Google Street View panoramas - #6
Open
dmbaty wants to merge 5 commits into
Open
Conversation
Added format conversion, specifically for non-official SV pano IDs
Smaller panos do not have zoom level 5, causing issues with scaling
Panos with max width of 8192 or smaller do not have high quality (zoom 5) available, added check to bump down to medium automatically
Added return type and updated comment on quick and dirty detection of pano ID type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds support for non-Google Street View panoramas, and includes proper support for handling lower resolution panoramas.
Changes
cli.py:core.py:metadata.py:Notes