Quick Download by Coordinates - #5
Open
idbnstra wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a streamlined way to download Street View panoramas using coordinates directly, without requiring a Google Maps URL. It adds a new
--quick(-q) flag and individual--lat/--lngoptions to the main download command.Rationale
Previously, downloading by coordinates was a two-step process:
streetview-dl queryto discover panoramas and generate a URL file.streetview-dl --batchto download from that file.While the
querycommand is excellent for discovery and exploration, some users might just want the closest panorama to a specific point. This PR provides a "fast path" for that use case.Key Features
--quick/-qoption: Accepts a"lat,lng"string (e.g.,-q 42.5,-94.1).--lat/--lngoptions: Separate flags for easier programmatic use in scripts.process_locationfunction now handles both URL-based and coordinate-based inputs, ensuring all filters, cropping, and quality settings work identically for both modes.Changes
streetview_dl/cli.py:maincommand.process_single_urlintoprocess_locationto handle coordinates.README.md:queryvs.--quick.tests/test_cli.py:test_cli_quick_optionto verify correct argument parsing and logic branching.test_cli_quick_option_invalid_formatto verify error handling for malformed coordinate strings.Usage Examples
Related Subcommand
The
querycommand remains the primary tool for: