Draft
security: fix SSRF, cleartext fetch, error disclosure, and tainted URL flow in handlers#23
Conversation
Copilot
AI
changed the title
[WIP] Remediate selected batch of 4 units
security: fix SSRF, cleartext fetch, error disclosure, and tainted URL flow in handlers
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four reachable security findings in
FetchTool,SafeAIAnswer, andParseLanguage: unvalidated user-controlled URLs reachinghttp.Get(CWE-319 / CWE-918), and rawerr.Error()strings written directly to HTTP responses.URL validation (
internal/safety/guards.go)SafeFetchURL(rawURL)— rejects non-httpsschemes, resolves the hostname via DNS, and checks every returned address against a comprehensive private/reserved CIDR blocklist (RFC 1918, loopback, CGNAT, link-local, multicast, documentation ranges, IPv6 equivalents)init()panics on any malformed built-in CIDR to surface programming errors at startupSSRF + cleartext fix (
internal/handlers/suspicious.go)FetchToolnow callsSafeFetchURLbeforehttp.Get; invalid/private URLs are rejected with a generic 400 before any network I/Ohttp.Error(w, err.Error(), …)replaced with generic messages; originals logged server-sideError disclosure (
internal/handlers/ai.go,internal/handlers/cve.go)SafeAIAnswer: JSON decode error no longer echoed to client ("invalid request body")ParseLanguage: language parse error no longer echoed to client ("invalid language tag")