Skip to content

fix(vdw): make dimensionality fallback transparent#64

Closed
sigilmakes wants to merge 1 commit into
contracts/56-stage-invariantsfrom
docs/41-vdw-followups
Closed

fix(vdw): make dimensionality fallback transparent#64
sigilmakes wants to merge 1 commit into
contracts/56-stage-invariantsfrom
docs/41-vdw-followups

Conversation

@sigilmakes

Copy link
Copy Markdown
Collaborator

What

  • correct stale dimensionality and vdW contract documentation
  • document D3BJ auto-enable as a conservative low-dimensional heuristic distinct from SOC consideration
  • make expected CrystalNN/Larsen failures produce an actionable analysis warning
  • let unexpected programming exceptions propagate
  • add Quantum ESPRESSO generation coverage for TS and MBD

Stack

How to test

  • uv run pytest -q — 262 passed
  • Ruff check and format check
  • pre-commit
  • expected/unexpected dimensionality failure probes
  • independent GPT-5.6 review — ready

Closes #41.


Written by an agent on behalf of Willow.

@sigilmakes sigilmakes added not ready: needs human Issue or PR that has not had human review yet cleanup Code cleanup and consistency work labels Jul 16, 2026
@sigilmakes

Copy link
Copy Markdown
Collaborator Author

This draft has been superseded by the consolidated cleanup PR #68. Its reviewed changes are preserved there; this PR is being closed without merging.


Written by an agent on behalf of Willow.

@sigilmakes sigilmakes closed this Jul 16, 2026
@sigilmakes
sigilmakes deleted the docs/41-vdw-followups branch July 16, 2026 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup Code cleanup and consistency work not ready: needs human Issue or PR that has not had human review yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant