fix: restore missing entrypoint + green CI (lint v2) - #2
Merged
Conversation
The lint job failed with golangci-lint exit code 3: the workflow pinned golangci-lint-action@v6 (v1-era), which cannot read the version: "2" config. Upgrade to golangci-lint-action@v9 and pin golangci-lint v2.12.2. Also satisfy the linters it now runs: check the previously-ignored Close() returns in main and config (explicit _ =), and exempt errcheck from test files (unchecked body Close in tests is noise). Fix .gitignore: the bare `robin` pattern matched the cmd/robin/ source directory; narrow it to /robin (root build output only). Verified locally with golangci-lint v2.12.2: 0 issues; build/vet/test -race green. The build-test job was already passing.
stephnangue
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the failing
lintjob onmain(thebuild-testjob was already green).Cause: the workflow used
golangci-lint-action@v6(v1-era), which cannot parse theversion: "2"config — golangci-lint exited with code 3 (a run failure, not lint findings).Fix:
golangci-lint-action@v9and pingolangci-lint v2.12.2.Close()returns (cmd/robin/main.go,internal/config/config.go).errcheckfrom_test.go(unchecked response/request-bodyClose()in tests is noise).Verified locally with golangci-lint v2.12.2 → 0 issues;
go build/go vet/go test -raceall green.