Skip to content

converting hardcoded sdk to use the variables #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cesine wants to merge 1 commit into
base: master
Choose a base branch
from
Open

converting hardcoded sdk to use the variables #44

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ buildscript {
configure(allprojects) {
group = 'com.octo.android'

ext.androidMinSDKVersion = "7"
ext.androidVersion = "4.1.1.4"
ext.androidSDKVersion = "17"
ext.androidBuildToolsVersion = "17.0"
Expand Down Expand Up @@ -74,7 +75,7 @@ project('android-sample') {

android {
buildToolsVersion "$androidBuildToolsVersion"
compileSdkVersion 17
compileSdkVersion "$androidSDKVersion"

sourceSets {
main {
Expand Down Expand Up @@ -211,8 +212,8 @@ project('android-sample-robolectric-tests') {
}

android {
compileSdkVersion 17
buildToolsVersion "17.0.0"
compileSdkVersion "$androidSDKVersion"
buildToolsVersion "$androidBuildToolsVersion"

sourceSets {
main {
Expand All @@ -237,8 +238,8 @@ project('android-sample-robolectric-tests') {
}

defaultConfig {
minSdkVersion 7
targetSdkVersion 17
minSdkVersion "$androidMinSDKVersion"
targetSdkVersion "$androidSDKVersion"
}
}

Expand Down Expand Up @@ -306,7 +307,7 @@ project('android-sample-espresso-tests') {

android {
buildToolsVersion "$androidBuildToolsVersion"
compileSdkVersion 17
compileSdkVersion "$androidSDKVersion"

sourceSets {
main {
Expand Down