Regenerated the libwebp wrapper so it matches the library layout#20
Merged
Conversation
Owner
Author
|
Remedies #13 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #20 +/- ##
==========================================
+ Coverage 28.72% 32.25% +3.53%
==========================================
Files 5 5
Lines 383 341 -42
==========================================
Hits 110 110
+ Misses 273 231 -42 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Regenerated src/Wrapper.jl from gen so the wrapper matches libwebp_jlls library layout. The Clang.jl-based generator emitted every wrapper against libwebp even though libwebp_jll splits the API across libwebp, libwebpdemux, and libwebpmux. That mismatch left demux and mux entry points bound to the wrong shared library and broke animated and container-related APIs at runtime. Updated the generator configuration to route declarations from demux.h to libwebpdemux and declarations from mux.h and mux_types.h to libwebpmux. Added an ignorelist for inline-only convenience wrappers because those names appear in the headers but are not exported by the shared libraries, so generating Julia ccall wrappers for them would create invalid bindings.
stemann
force-pushed
the
feature/generated-wrapper-libraries
branch
from
April 9, 2026 07:07
a66f48d to
b8a91f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regenerated src/Wrapper.jl from gen so the wrapper matches libwebp_jlls library layout.
The Clang.jl-based generator emitted every wrapper against libwebp even though libwebp_jll splits the API across libwebp, libwebpdemux, and libwebpmux. That mismatch left demux and mux entry points bound to the wrong shared library and broke animated and container-related APIs at runtime.
Updated the generator configuration to route declarations from demux.h to libwebpdemux and declarations from mux.h and mux_types.h to libwebpmux. Added an ignorelist for inline-only convenience wrappers because those names appear in the headers but are not exported by the shared libraries, so generating Julia ccall wrappers for them would create invalid bindings.