feat - show excerpts if the settings enabled. - #78
Open
nishitlangaliya wants to merge 2 commits into
Open
nishitlangaliya wants to merge 2 commits into
nishitlangaliya wants to merge 2 commits into
Conversation
DevinWalker
suggested changes
Sep 28, 2018
| return sprintf( '<label class="inline_label">%1$s</label><span class="hint--top hint--top-multiline" aria-label="%2$s"><span | ||
| class="dashicons gmb-tooltip-icon"></span></span>', | ||
| esc_html__( 'Show Excerpts', 'google-maps-builder' ), | ||
| esc_html__( "Would you like to display excerpts of post content instead of full content ?", 'google-maps-builder' ) |
There was a problem hiding this comment.
- Use single quotes.
- Update text to:
Would you like to display the post excerpt instead of the post content?
Contributor
Author
There was a problem hiding this comment.
@DevinWalker sure I am doing the changes and will let you know soon.
|
Please fix content and resolve conflict |
Contributor
Author
|
@DevinWalker , I have fixed the conflict and done the changes as per suggestion. |
…Core into issue/235-excerpt # Conflicts: # includes/misc-functions.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR will fix stellarwp-sunset/google-maps-builder#235
How Has This Been Tested?
Manually Tested
Types of changes
New feature (non-breaking change which adds functionality)
Checklist: