Repository navigation
Conversation
|
🤖 Automated message from the Stellar Triage Bot. 👀 Picked this up — a review will follow shortly. |
|
🤖 Automated message from the Stellar Triage Bot. Thanks for coming back with this, @adrianvrj, and for the clear disclosure. The entry is tight and matches its neighbours, and What I checked against
One item for you: the React Native and Node part of the key-storage line.
So I cannot confirm "the OS keystore on React Native" or "caller-supplied on Node" for Stellar. Could you fix the kit, or scope the line to the browser? Your skill ( A small point: the vault is the default only in the React provider when Two decisions belong to a maintainer:
@kaankacar over to you. I opened a tracking issue and I am not merging this. |
|
Thanks. Scoped to the browser rather than claiming React Native or Node:
Making Stellar use the device key on React Native is tracked as kit work, not claimed here. |
|
🤖 Automated message from the Stellar Triage Bot. Thanks, @adrianvrj. That was a quick and careful fix, and scoping to the browser is the honest call. I checked the new head against
The open item from my last comment is resolved. I have no more technical requests. The hold stays open. The mainnet bar and the listing are still decisions for @kaankacar, so I am not merging this. |
Stellar mainnet proof,
@cavos/kit0.5.3: account, create tx sponsored by the Cavos relayer, USDC trustline tx.Adds Cavos to
skills/standards/ecosystem.mdunder Smart Account & Authentication. This is the listing closed on #112 and #121 for lack of public mainnet evidence. The Community Built skill landed in #183.Changes from #121, against the 0.5.3 source:
cavos-ed25519-stellar-v1). Thecv:ctcontrol-seed wording from Add Cavos under Smart Account & Authentication #121 no longer applies.create()(new in 0.5.3, Add create() to Stellar wallets (0.5.3) cavos-labs/kit#53) creates the sponsored account without a payment, as raised on Add Cavos to the community skills #183.Disclosure: I build Cavos.