Skip to content

fix: link workspace packages in generated pnpm-workspace.yml #658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zachfedor wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: link workspace packages in generated pnpm-workspace.yml #658

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions crates/stellar-scaffold-cli/src/commands/init/instantiate.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,13 +243,18 @@ fn rewrite_root_workspaces(root: &Path) -> Result<(), Error> {

/// pnpm-workspace.yaml contents mirroring the instantiated workspaces. pnpm
/// reads workspace globs from this file rather than `package.json`.
///
/// `linkWorkspacePackages` is required because templates depend on
/// `@stellar-scaffold/app-lib` via `"*"` (parsable by npm rather than pnpm's
/// preferred `"workspace:*"`). Newer versions of pnpm default to false.
fn pnpm_workspace_yaml() -> String {
let mut out = String::from("packages:\n");
for ws in INSTANTIATED_WORKSPACES {
out.push_str(" - \"");
out.push_str(ws);
out.push_str("\"\n");
}
out.push_str("linkWorkspacePackages: true\n");
out
}

Expand Down Expand Up @@ -553,6 +558,8 @@ mod tests {
assert!(yaml.contains("- \"app\""));
assert!(yaml.contains("- \"app-lib\""));
assert!(yaml.contains("- \"app-lib/clients/*\""));
// the leading `\n` ensures this is a top-level key, not nested under packages
assert!(yaml.contains("\nlinkWorkspacePackages: true\n"));

let config = fs::read_to_string(root.join("scaffold.yml")).unwrap();
assert!(config.contains(" contracts-dir: contracts\n package-manager: pnpm@1.2.3\n"));
Expand Down
Loading