Repository navigation
fix: read-only commands don't require a source account - #112
Merged
Merged
Conversation
fetch-contract-id, fetch-hash, current-version, download, fetch-account-id, fetch-account-owner and create-alias only simulate reads, which work with any public key. Make --source-account optional for them, so import_contract! builds in CI without an identity. Closes #111 Co-Authored-By: Claude <noreply@anthropic.com>
Replace ReadArgs with a clap mut_arg on each read-only command, so they keep global::Args and call sites stay `&self.config`. Co-Authored-By: Claude <noreply@anthropic.com>
pselle
marked this pull request as ready for review
November 6, 2026 17:08
willemneal
approved these changes
Nov 8, 2026
Merged
pselle
pushed a commit
that referenced
this pull request
Nov 9, 2026
## 🤖 New release
* `stellar-registry-macro`: 0.1.3 -> 0.1.4
* `stellar-registry`: 0.1.3 -> 0.1.4 (✓ API compatible changes)
* `stellar-registry-build`: 0.2.0 -> 0.3.0 (⚠ API breaking changes)
* `stellar-registry-cli`: 0.3.0 -> 0.3.1 (✓ API compatible changes)
### ⚠ `stellar-registry-build` breaking changes
```text
--- failure enum_variant_added: enum variant added on exhaustive enum ---
Description:
A publicly-visible enum without #[non_exhaustive] has a new variant.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#enum-variant-new
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.51.0/src/lints/enum_variant_added.ron
Failed in:
variant Error:NoLocalRegistry in /tmp/.tmpx1tFqO/cli/crates/stellar-registry-build/src/error.rs:35
variant Error:NoLocalRegistry in /tmp/.tmpx1tFqO/cli/crates/stellar-registry-build/src/error.rs:35
```
<details><summary><i><b>Changelog</b></i></summary><p>
## `stellar-registry-macro`
<blockquote>
##
[0.1.4](stellar-registry-macro-v0.1.3...stellar-registry-macro-v0.1.4)
- 2026-11-09
### Added
- support Stellar Asset Contracts in register_import!
([#82](#82))
- add register_import! for testing import_contract! callers
([#77](#77))
</blockquote>
## `stellar-registry`
<blockquote>
##
[0.1.4](stellar-registry-v0.1.3...stellar-registry-v0.1.4)
- 2026-11-09
### Added
- support Stellar Asset Contracts in register_import!
([#82](#82))
- add register_import! for testing import_contract! callers
([#77](#77))
</blockquote>
## `stellar-registry-build`
<blockquote>
##
[0.3.0](stellar-registry-build-v0.2.0...stellar-registry-build-v0.3.0)
- 2026-11-09
### Added
- add register_import! for testing import_contract! callers
([#77](#77))
</blockquote>
## `stellar-registry-cli`
<blockquote>
##
[0.3.1](stellar-registry-cli-v0.3.0...stellar-registry-cli-v0.3.1)
- 2026-11-09
### Added
- add register_import! for testing import_contract! callers
([#77](#77))
### Fixed
- read-only commands don't require a source account
([#112](#112))
### Other
- *(deps)* bump shlex from 1.3.0 to 2.0.1
([#105](#105))
</blockquote>
</p></details>
---
This PR was generated with
[release-plz](https://github.com/release-plz/release-plz/).
Co-authored-by: aha-release-plz[bot] <211513279+aha-release-plz[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #111.
Each read-only command uses clap's
mut_argto make--source-accountoptional. When no source is given, the command simulates as the all-zeros public key, since simulation doesn't need a funded account. Commands that send transactions still require a source.I checked
fetch-contract-id,current-version,fetch-hashanddownloadon testnet with an empty config and noSTELLAR_ACCOUNT.publishstill errors without a source. The integration tests weren't run, because they need a local quickstart.