Skip to content

Remove non-standard properties from schemas#18

Merged
martijnversluis merged 1 commit into
mainfrom
s2-standard
Jul 21, 2026
Merged

Remove non-standard properties from schemas#18
martijnversluis merged 1 commit into
mainfrom
s2-standard

Conversation

@martijnversluis

Copy link
Copy Markdown
Contributor

No description provided.

@jorritn

jorritn commented Jun 22, 2026

Copy link
Copy Markdown

Thanks @martijnversluis. Shouldn't the fields also be removed from the ruby object types? E.g.

attribute :measurement_timestamp, Types::String

@jorritn

jorritn commented Jun 24, 2026

Copy link
Copy Markdown

I've created a PR for the S2 Documentation site that adds a link to this GitHub project. If this issue is resolved, I'll merge that PR as well.

@martijnversluis

Copy link
Copy Markdown
Contributor Author

Thanks @martijnversluis. Shouldn't the fields also be removed from the ruby object types? E.g.

attribute :measurement_timestamp, Types::String

I think that link points to the main branch, the change is still in this branch:

class FRBCStorageStatus < Dry::Struct

@jorritn

jorritn commented Jun 24, 2026

Copy link
Copy Markdown

Sorry! My bad. Then this is resolved.

@jorritn

jorritn commented Jul 20, 2026

Copy link
Copy Markdown

@martijnversluis It would be nice if we can close this one. Can you merge it?

@martijnversluis
martijnversluis merged commit 4175477 into main Jul 21, 2026
2 checks passed
@martijnversluis
martijnversluis deleted the s2-standard branch July 21, 2026 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants