Further improvements of fixing the renaming#28
Open
tobyjamez wants to merge 11 commits into
Open
Conversation
added 11 commits
August 10, 2023 13:20
Owner
|
@tobyjamez I'm a little confused what the difference is between new-fix-rename and fix-rename is? Or is new-fix-rename just fix-rename plus logging? |
Collaborator
Author
|
fix-rename only fixed the issue in the line identified in issue #14, but the same issue appears a few other times throughout the codebase. this addresses them. you're right though that this should really be a PR to the logging branch i guess? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Probably fully resolves issue #14 (I can't find any other instances of this issue)