Skip to content

Remove dormant user-location SSE subscription - #258

Merged
stef-k merged 2 commits into
mainfrom
fix/256-remove-dormant-user-sse
Aug 29, 2026
Merged

Remove dormant user-location SSE subscription#258
stef-k merged 2 commits into
mainfrom
fix/256-remove-dormant-user-sse

Conversation

@stef-k

@stef-k stef-k commented Aug 29, 2026

Copy link
Copy Markdown
Owner

Summary

  • remove the unreachable mobile SubscribeToUserAsync interface and implementation
  • remove tests and current documentation owned only by the nonexistent mobile user-location endpoint
  • retain shared Bearer and SSE Accept coverage through the active group subscription
  • preserve all active group and visit SSE behavior

Closes #256

Product behavior

WayfarerMobile no longer exposes a dormant method targeting the nonexistent endpoint:

/api/mobile/sse/location-update/{userName}

Current production has no caller for that method. Active authenticated group and visit streams remain unchanged, including their event parsing, reconnection, cancellation, disposal, stale-client isolation, and visit polling fallback.

No replacement or redirect to Wayfarer's distinct generic web location stream is introduced.

Compatibility

  • released mobile versions contained the method but had no production call site
  • installed clients and backend-first deployment compatibility are unaffected
  • Wayfarer backend code and endpoints are unchanged
  • no authentication, Timeline synchronization, Trip, routing, persistence, schema, or migration changes

Validation

  • SseClientTests: 30 passed
  • group/SSE-management selection: 69 passed
  • visit notification/fallback selection: 55 passed
  • complete suite: 1,886 passed, 0 failed, 0 skipped
  • Release test/Core build: passed, 9 retained unrelated warnings
  • Android Release build: passed, 0 errors, 133 retained package/XAML warnings
  • final dead-surface searches: no remaining method, route, or stale user-channel claim
  • git diff --check 89d5404c...HEAD: passed
  • no real service/provider contact

Code Guard

Code Guard reports SseClient.cs at 640 counted LOC, reduced from 657. The user explicitly approved a narrow exception for issue #256 at exact head db4462bb18e5b1666bed5a61fa03ae1a9b9abb9e.

The exception:

  • applies only to this shrinking dead-surface-removal change;
  • does not authorize future growth;
  • creates no baseline, suppression, exclusion, grandfathering rule, or threshold change;
  • does not waive other findings.

No other Code Guard FAIL or INCOMPLETE exists.

UI evidence

No screenshot is needed: no reachable UI behavior changes.

@github-actions

Copy link
Copy Markdown

Code Coverage

Package Line Rate Branch Rate Complexity Health
WayfarerMobile.Core 87% 79% 1000
Summary 87% (1381 / 1579) 79% (691 / 874) 1000

@stef-k
stef-k merged commit 421cd73 into main Aug 29, 2026
1 check passed
@stef-k
stef-k deleted the fix/256-remove-dormant-user-sse branch August 29, 2026 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove dormant user-location SSE subscription seam

1 participant