Remove dormant user-location SSE subscription - #258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SubscribeToUserAsyncinterface and implementationAcceptcoverage through the active group subscriptionCloses #256
Product behavior
WayfarerMobile no longer exposes a dormant method targeting the nonexistent endpoint:
/api/mobile/sse/location-update/{userName}Current production has no caller for that method. Active authenticated group and visit streams remain unchanged, including their event parsing, reconnection, cancellation, disposal, stale-client isolation, and visit polling fallback.
No replacement or redirect to Wayfarer's distinct generic web location stream is introduced.
Compatibility
Validation
SseClientTests: 30 passedgit diff --check 89d5404c...HEAD: passedCode Guard
Code Guard reports
SseClient.csat 640 counted LOC, reduced from 657. The user explicitly approved a narrow exception for issue #256 at exact headdb4462bb18e5b1666bed5a61fa03ae1a9b9abb9e.The exception:
No other Code Guard
FAILorINCOMPLETEexists.UI evidence
No screenshot is needed: no reachable UI behavior changes.