Fix peer visibility HTTP method compatibility - #257
Merged
Conversation
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POSTendpointGroupsServicewith deterministic awaited captureCloses #254
Product behavior
The Groups peer-visibility toggle now sends exactly one authenticated request using:
POST /api/mobile/groups/{groupId}/peer-visibilityThe existing
{ "disabled": true|false }body and UI success/failure behavior are unchanged. No dual-verb retry, compatibility probe, fallback, backend change, or state redesign is included.Validation
GroupsServicetests: 3 passed on three consecutive runsgit diff --check 07524b34...HEAD: passedTest ownership
The focused tests source-link and instantiate the actual production
GroupsService. Request content is captured inside one awaitedSendAsyncreturn delegate, so assertions cannot race request disposal or unawaited callbacks.Migration and API notes
UI evidence
No screenshot is needed: the existing toggle and user-facing behavior are unchanged; this corrects its internal HTTP verb.