feat(witnesses): align witness voting with legacy#301
Merged
Conversation
Add quick vote by username input, witness proxy broadcast, rank by vote order, and login dialog for auth-required actions.
Split list vs action loading, add success toasts, surface broadcast details, and keep witness-vote UI stable with optimistic updates while refetching fresh account state.
Add unit tests for degradation-state to keep coverage thresholds passing.
Use a typed global cast to replace fetch in tests without triggering unused ts-expect-error warnings.
- Remove unnecessary double type assertion on currentProxy (SteemAccount already has proxy? field) - Add signingKey guard in pendingAction effect run() to handle async key clearing - Extract DISABLED_SIGNING_KEY to src/lib/steem/constants.ts for reuse - Add afterEach reset in degradation-state test to prevent cross-test leakage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/witnessesvoting UI with legacy (quick vote by account, proxy set/clear, vote list ordering).Test plan
pnpm verify/witnesses