Add withLog() for logging alongside metrics - #28
Merged
Merged
Conversation
Adds Metric::withLog() to log a message when a metric is flushed.
The log message is included in the metric's extra as 'message', and
the log context includes the metric's extra plus an 'event' key.
Also fixes PostHog to batch metrics like other drivers instead of
sending immediately in add(), which broke fluent chaining like
Metrics::create('event')->setExtra([...]).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Metric::withLog(string $message, string $level = 'info')to log a message when a metric is flushed'message' => $logMessage['event' => $metricName]merged with the metric's extraflushMetricLogs()so all extra data is finalizedadd(), which broke fluent chaining (Metrics::create('event')->setExtra([...]))Usage
Test plan
withLog()stores message and level, defaults toinfogetExtra()includesmessagekey when log is set