Add lazy userId resolver for drivers - #25
Merged
Merged
Conversation
Replaces the eagerly-evaluated distinctId on the PostHog driver with a closure-based resolveUserIdWith() on AbstractDriver. The default auth/session/random logic now evaluates at metric dispatch time, not at singleton creation. The resolver can also be set on MetricsManager to propagate to all drivers.
The auth/session/random fallback logic now lives in AbstractDriver::getUserId() so all drivers get sensible defaults. Custom resolvers can still override via resolveUserIdWith(). PostHog handles its distinct_prefix internally.
Custom resolvers own the full ID. The prefix is only prepended when falling back to the built-in auth/session/random resolution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolveUserIdWith(\Closure)andgetUserId()toAbstractDriver, available to all driversresolveUserIdWith(\Closure)toMetricsManagerwhich propagates to all drivers on creation$this->getUserId()instead of a static$distinctIdconstructor paramstatic $anonymousIdTest plan
format()call)getUserId()returns null when no resolver is set