Remove init from filter#265
Draft
SamDuffield wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #253
Currently just an early draft to get feedback before fixing the tests etc.
An alternative to #264, instead of adding an optional
init_statearg we make it compulsory and force the user to initiate the state.This has slightly less flexibility but doesn't add an optional arg and leaves the user with one and only one way to do it.
I've left
model_inputsininit_prepare, in many cases they might not be needed although the user would still be required to provide e.g. aNone. But this change does provide a nice feature in that the shapes of theinit_model_inputsandfilter_model_inputsno longer need to match which is convenient in the majority of cases.