Move from pyright to ty#262
Merged
Merged
Conversation
AdrienCorenflos
approved these changes
Jun 18, 2026
AdrienCorenflos
left a comment
AdrienCorenflos
left a comment
Contributor
There was a problem hiding this comment.
No pb with it, I like the forced named argument
Sahel13
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ty is faster and finally has a pre-commit which also doesn't require dependencies duplicated in the pre-commit config like pyright did.
This should be essentially no change to the code, the only thing is that all arguments after
model_inputsbecome keyword-only (that's what the*does). keyword-only plays much nicer withpartial, which ty flags but pyright did not.There are also a couple of issues with how we do docstrings in the resampling atom and the use of
TypeVarin the factorial code. But I've told ty to ignore these for now and can raise issues and subsequent PRs.