[9.x] Fix N+1 queries when augmenting relationships - #843
Merged
Conversation
`toAugmentedArray` resolves every `Value`, which for a relationship means lazy loading it, so augmenting a relationship queried each related model's own relationships whether or not the template used them. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Released as part of v9.6.2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where augmenting a relationship would trigger an N+1 query for each of the related models' own relationships.
This was happening because
toAugmentedArrayresolves everyValueup-front. For most Statamic data that's cheap, since resolving a relationship just returns the raw IDs. In Runway, the raw value of a relationship is$model->getAttribute($handle), which lazy loads it. So augmenting ahas_manyfield queried every relationship on every related model, whether or not the template used them.This PR fixes it by using
toDeferredAugmentedArrayinstead, so eachValueis only resolved when something actually asks for it. This is the same thing Statamic does when hydrating the cascade.This PR also swaps out the same pattern in a few other places which augment a whole model just to use one or two keys:
{{ runway }}tag.runway:rebuild-uri-cache), which was loading every relationship just to parse/posts/{{ slug }}.title_formaton the relationship fieldtypes.Fixes #777