Allow cropping images to templates in the performer edit form - #1216
Open
Maista6969 wants to merge 9 commits into
Open
Allow cropping images to templates in the performer edit form#1216Maista6969 wants to merge 9 commits into
Maista6969 wants to merge 9 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to make this a stacked PR but I didn't realize you need write access to the repository for that 😅 This PR depends on the changes in #1215 and expands on it by adding a crop-to-template feature that would resolve #212 : choosing certain image labels (bust, face, three-quarter, etc.) offers a matching crop frame with guides drawn from a set of built-in template files. Cropping is optional, just like labeling.
I looked into oov/psd for working with the template files but it didn't support everything the templates from actress-pics uses so I ended up with a hand-rolled implementation that grabs only the parts we need. This is more code, but it's quite minimal. Using the PSD templates as the single source of truth means that we can offer these templates for downloads to users who might want to use their own image editing software.
For review purposes I've deployed this branch to https://image-box.maista.no and you can find a list of user logins in a thread on Discord.