test(engine): expect camelCase viewBox in serialized inline SVG#96
Merged
Conversation
The HTML parser now applies the SVG attribute-case adjustment table (viewbox -> viewBox), so InlineSvgSerializer round-trips the canonical camelCase name. Update the stale assertion that expected the old lowercased form. Surfaced once the NU1903 restore fix let CI run the unit tests again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the merged HTML tree-construction work: the parser now applies the SVG attribute-case adjustment (
viewbox→viewBox), so the inline-SVG serializer emits canonicalviewBox. Updates the one staleInlineSvgFetcherTestsassertion that expected the old lowercase form (it surfaced once #91 let CI run the unit tests again). Test passes (3/3).