feat: DAI Fast Withdrawals#190
Draft
nulven wants to merge 212 commits into
Draft
Conversation
## [1.4.0-dev.1](starknet-io/starkgate-frontend@v1.3.1-dev.5...v1.4.0-dev.1) (2022-05-03) ### 🧩 Features * add asset to SN wallet after a successful deposit ([starknet-io#171](starknet-io#171)) ([30d8ec3](starknet-io@30d8ec3))
## [1.4.0](starknet-io/starkgate-frontend@v1.3.0...v1.4.0) (2022-05-04) ### 🔧 Fixes * cancel toFixed when format balances ([starknet-io#172](starknet-io#172)) ([2906e3e](starknet-io@2906e3e)) * connection modal overrides gsw selection modal ([starknet-io#175](starknet-io#175)) ([73b1f21](starknet-io@73b1f21)) * temporary disable max button ([starknet-io#173](starknet-io#173)) ([1d3038d](starknet-io@1d3038d)) * update app state on accountsChanged event ([starknet-io#176](starknet-io#176)) ([3161cc9](starknet-io@3161cc9)) * update text for the attempt to deposit more than the allowable amount ([starknet-io#174](starknet-io#174)) ([d8f3da8](starknet-io@d8f3da8)) ### 🧩 Features * add asset to SN wallet after a successful deposit ([starknet-io#171](starknet-io#171)) ([30d8ec3](starknet-io@30d8ec3))
### [1.4.1-dev.1](starknet-io/starkgate-frontend@v1.4.0...v1.4.1-dev.1) (2022-05-08) ### 🔧 Fixes * CompleteTransferToL1 toast remains on display after tx is done ([starknet-io#179](starknet-io#179)) ([219b860](starknet-io@219b860))
### [1.4.1-dev.2](starknet-io/starkgate-frontend@v1.4.1-dev.1...v1.4.1-dev.2) (2022-05-08) ### 🔧 Fixes * **Header:** testnet title not displayed ([4169584](starknet-io@4169584))
### [1.4.1](starknet-io/starkgate-frontend@v1.4.0...v1.4.1) (2022-05-08) ### 🔧 Fixes * CompleteTransferToL1 toast remains on display after tx is done ([starknet-io#179](starknet-io#179)) ([219b860](starknet-io@219b860)) * **Header:** testnet title not displayed ([4169584](starknet-io@4169584))
### [1.4.2-dev.1](starknet-io/starkgate-frontend@v1.4.1...v1.4.2-dev.1) (2022-05-10) ### 💉 Improvements * export convention ([starknet-io#180](starknet-io#180)) ([b5585ad](starknet-io@b5585ad))
### [1.4.2-dev.2](starknet-io/starkgate-frontend@v1.4.2-dev.1...v1.4.2-dev.2) (2022-05-10) ### 💉 Improvements * tokens addresses ([starknet-io#178](starknet-io#178)) ([c75a88a](starknet-io@c75a88a))
## [1.5.0-dev.1](starknet-io/starkgate-frontend@v1.4.2-dev.2...v1.5.0-dev.1) (2022-05-11) ### 🧩 Features * MultiChoiceMenu component ([starknet-io#181](starknet-io#181)) ([bbf19ba](starknet-io@bbf19ba)) ### 🔧 Fixes * change transfer tabs names ([starknet-io#182](starknet-io#182)) ([e795f1c](starknet-io@e795f1c))
dan-ziv
self-requested a review
May 18, 2022 06:36
maciejka
reviewed
May 18, 2022
| ); | ||
| }; | ||
|
|
||
| export const useFastTransferToL1 = () => { |
There was a problem hiding this comment.
What will happen if frontend is reloaded after fast transfer is initiated? Will it resume the withdrawal process?
This reverts commit 307dd6e.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Please add a detailed description of the change, whether it's an enhancement or a bugfix.
If the PR is related to an open issue please link to it.
Checklist
<type>[optional scope]: <description>, e.g:fix: prevent racing of requestsThis change is