Fix Google Photos pagination & high-res portraits (closes #155) - #168
Open
starbrightlab wants to merge 1 commit into
Open
Fix Google Photos pagination & high-res portraits (closes #155)#168starbrightlab wants to merge 1 commit into
starbrightlab wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picks @miguelsg29's Google Photos fix (
8a31dec, originally in #164) onto a clean branch offmain, decoupled from the Spanish i18n sweep so it can land on its own. Authorship preserved.What it does (closes #155)
batchexecuteRPC (extractGoogleAlbumKey/extractGoogleContinuationToken/fetchGoogleBatchRpcinRemoteAlbum.kt) so albums with >30 photos load beyond the initial HTML chunk (hard-capped at 100 pages / 10k photos).=w{maxDim}-h{maxDim}-noat max screen dimension; aspect-preserving background blur, dual-layer crossfade, clipped Ken-Burns frame, and an opt-incropVerticaltoggle (added as aBoolSpec, tripwire-clean).Review notes (from deep review)
PhotoFrameController.kt:1591) — a per-transition hitch on the Portal CPU; ideally moved to theioexecutor in a follow-up.Testing
./gradlew :app:compileDebugKotlin+RemoteAlbumTest— green. (The new tests cover the key/token extractors against fixtures; they don't exercise a real Google payload.)Closes #155. Original work by @miguelsg29 (split out of #164).