Feature/digital world clock - #165
Open
miguelsg29 wants to merge 12 commits into
Open
Conversation
…e aplicaciones al espanol
…active zone count
starbrightlab
left a comment
Owner
There was a problem hiding this comment.
Nice addition — reviewed the two world-clock commits (independent of the i18n base). Correctness is solid: DST-safe (TimeZone.getTimeZone(zone)), respects use24HourClock (AUTO/12/24), and the LaunchedEffect tick actually updates. Integration follows the existing analog-widget pattern at all the right points, DisposableEffect cleans up the observer, no new persisted setting → tripwires stay green. This is close to mergeable.
A few nits before merge:
- Don't repurpose the Timers glyph.
ca7cab9changed the shipped Timers icon⏱ → ⌛purely to free⏱for the new clock (HomeActivity.kt:3198). That silently alters an existing widget (and an hourglass suits a timer worse). Please give the digital clock its own glyph and leave Timers as-is. - Tick per-minute, not per-second. The digital face shows only
HH:mmyet wakes every second (delay(1000)), andremember(zone, now, ...)re-keys onnowso it memoizes nothing. On an always-on OLED launcher, per-minute is easier on power/burn-in. - Optional: the digital and analog widgets share ~all their scaffolding (state, lifecycle observer, tick, responsive layout) — a shared helper would avoid future double-maintenance. And at 3–4 zones the time
TextismaxLines=1with nooverflow = Ellipsis, so a wide "12:45 PM" can clip.
Fix 1 and 2 and I'm happy to merge.
… handle overflow in Digital World Clock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new built-in Digital World Clock widget alongside the existing analog world clock:
ImmortalSettings.use24HourClock(12-hour vs 24-hour format).I18n.kt.