Replace curl with native Go http client for proxy support and better error handling - #60
Open
dntil wants to merge 1 commit into
Open
Replace curl with native Go http client for proxy support and better error handling#60dntil wants to merge 1 commit into
dntil wants to merge 1 commit into
Conversation
…port and better error handling
### What this PR does
Replaced the `exec.Command("curl"... )` implementation in `fDownload` with the already existing native Go method `httpDownloadCurlUA`.
### Why is this needed?
1. External OS `curl` ignores Docker/host `HTTP_PROXY`/`HTTPS_PROXY` configs, breaking extraction workflows when users deploy inside restricted network nodes.
2. Failed curl commands only output a non-descriptive `exit status 1` and swallow the root network cause from users.
3. This change leverages Go native `net/http` to provide implicit proxy routing, proper redirection tracking, explicit granular error bubbling, and properly spoofed user-agent headers.
Tested locally via customized Docker builds. Works flawlessly around strict network firewalls!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Replaced the
exec.Command("curl"... )implementation infDownloadwith the already existing native Go methodhttpDownloadCurlUA.Why is this needed?
curlignores Docker/hostHTTP_PROXY/HTTPS_PROXYconfigs, breaking extraction workflows when users deploy inside restricted network nodes.exit status 1and swallow the root network cause from users.net/httpto provide implicit proxy routing, proper redirection tracking, explicit granular error bubbling, and properly spoofed user-agent headers.Tested locally via customized Docker builds. Works flawlessly around strict network firewalls!