Updates-to-review#49
Open
aaronTredrea wants to merge 15 commits into
Open
Conversation
talezion
suggested changes
Jan 8, 2019
talezion
left a comment
talezion
left a comment
Contributor
There was a problem hiding this comment.
Do we need that in StanwoodAnimations?
Contributor
Author
|
Do we need that in StanwoodAnimations? Thats why it was raised for discussion.. some will and some wont. This was pushed before |
talezion
suggested changes
Jul 15, 2019
talezion
left a comment
talezion
left a comment
Contributor
There was a problem hiding this comment.
- We need MIT licence to all files
- Some access modifiers are missing
- Some docs are missing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Can we go through what we will keep first, then document ? I dont think this will all belong in core so might be better decide what we want where, then document ?