add yule_simon_lccdf - #3236
Conversation
Jenkins Console Log Machine informationNo LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focalCPU: G++: Clang: |
SteveBronder
left a comment
There was a problem hiding this comment.
One small change but I think this is good to merge as is
Co-authored-by: Steve Bronder <Stevo15025@gmail.com>
Jenkins Console Log Machine informationNo LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focalCPU: G++: Clang: |
SteveBronder
left a comment
There was a problem hiding this comment.
Two small things that would be nice but are non-blocking. Otherwise good!
Co-authored-by: Steve Bronder <Stevo15025@gmail.com>
Jenkins Console Log Machine informationNo LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focalCPU: G++: Clang: |
|
Thanks! |
Summary
With this PR the lccdf of Yule Simon distribution is added.
See issue #3235
Expressions involved:
Derivatives w.r.t the parameter
Tests
Test is written follow the guide.
Side Effects
No.
Release notes
yule_simon_lccdfis available if merged. Allows modeling power-law count data.Checklist
Copyright holder: Zhi Ling
The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)
the basic tests are passing
./runTests.py test/unit)make test-headers)make test-math-dependencies)make doxygen)make cpplint)the code is written in idiomatic C++ and changes are documented in the doxygen
the new changes are tested