maintain separate direct and Make-quoted stanc options - #1231
Merged
Conversation
Move deprecated-syntax guidance to standalone header failures and consistently use the stored absolute include paths during compilation.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1231 +/- ##
==========================================
- Coverage 91.92% 91.73% -0.20%
==========================================
Files 15 15
Lines 6267 6279 +12
==========================================
- Hits 5761 5760 -1
- Misses 506 519 +13 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
$compile(), $check_syntax() and $format() each turned stanc_options into
command line arguments with their own near-identical loop, and the three
had drifted apart: only $format() guarded against numeric values being
collapsed to a valueless flag. Replace all three with a single
stanc_options_to_args(), which takes a quote_values argument for the Make
path so the direct and Make-quoted forms stay in one place.
Boolean options are now keyed off is.logical() rather than
isTRUE(as.logical(value)). TRUE still emits a bare flag, FALSE now omits
the flag instead of emitting an invalid --flag=FALSE, and numeric values
are passed through as --name=value. Values spelled as the strings "TRUE"
and "FALSE" are no longer treated as flags.
$format() also assigned into stanc_options with [ rather than [[, which
coerced every element to a common type and so turned the logical TRUE for
auto-format into the string "TRUE". The old as.logical() coercion hid
this; assigning into a list keeps the types intact.
Drop the manual stanc_options = list("allow-undefined") from the
cpp_options user header test, which was masking the allow-undefined fix
and left that path without real coverage.
fixes #1233
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submission Checklist
Summary
Fixes #1227
Fixes #1233
In addition to those issues,
stancerrors during$compile()are now thrown immediately with thestancerror message attached, instead of returningNULLand failing laterCopyright and Licensing
Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Jonah
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses: