Skip to content

cleanly handle compiling with threads in compile doc - #1222

Merged
jgabry merged 1 commit into
masterfrom
fix-compile-example
Jul 24, 2026
Merged

cleanly handle compiling with threads in compile doc#1222
jgabry merged 1 commit into
masterfrom
fix-compile-example

Conversation

@jgabry

@jgabry jgabry commented Jul 23, 2026

Copy link
Copy Markdown
Member

Submission Checklist

  • Run unit tests
  • Declare copyright holder and agree to license (see below)

Summary

The $compile() example recompiles the CmdStan example model with stan_threads = TRUE. Because pkgdown before building vignettes, the cmdstanr.Rmd vignette then reused that threaded executable and errored when trying to run sampling.

This was always happening, but before #1212 the threading metadata went undetected due to the case-sensitivity bug.

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Jonah Gabry

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

The $compile() example recompiles the CmdStan example model with stan_threads = TRUE. Because pkgdown before building vignettes, the cmdstanr.Rmd vignette then reused that threaded executable and errored when trying to run sampling.

This was always happening, but before #1212 the threading metadata went undetected due to the case-sensitivity bug.
@codecov-commenter

codecov-commenter commented Jul 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.87%. Comparing base (4a3ddb8) to head (839ede6).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1222      +/-   ##
==========================================
+ Coverage   91.79%   91.87%   +0.08%     
==========================================
  Files          15       15              
  Lines        6249     6241       -8     
==========================================
- Hits         5736     5734       -2     
+ Misses        513      507       -6     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jgabry
jgabry merged commit d648cb5 into master Jul 24, 2026
14 of 15 checks passed
@jgabry
jgabry deleted the fix-compile-example branch July 24, 2026 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants