Skip to content

Don't permanently modify user's make/local in test suite - #1221

Merged
jgabry merged 2 commits into
masterfrom
tests/restore-make-local
Jul 24, 2026
Merged

Don't permanently modify user's make/local in test suite#1221
jgabry merged 2 commits into
masterfrom
tests/restore-make-local

Conversation

@jgabry

@jgabry jgabry commented Jul 23, 2026

Copy link
Copy Markdown
Member

Submission Checklist

  • Run unit tests
  • Declare copyright holder and agree to license (see below)

Summary

test-model-compile.R added PRECOMPILED_HEADERS=false to make/local on every test run and never removed it.

This PR adds a local_cmdstan_make_local() test helper that writes cpp_options to make/local and restores its original contents (or absence) at the end of the test file.

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Jonah Gabry

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@codecov-commenter

codecov-commenter commented Jul 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.79%. Comparing base (4a3ddb8) to head (fb0539c).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1221   +/-   ##
=======================================
  Coverage   91.79%   91.79%           
=======================================
  Files          15       15           
  Lines        6249     6249           
=======================================
  Hits         5736     5736           
  Misses        513      513           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jgabry
jgabry merged commit 44c7f66 into master Jul 24, 2026
14 of 15 checks passed
@jgabry
jgabry deleted the tests/restore-make-local branch July 24, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants