Fix compile method examples - #1219
Closed
jgabry wants to merge 2 commits into
Closed
Conversation
The model-method-compile example recompiled the CmdStan example model examples/bernoulli/bernoulli with stan_threads=TRUE. When pkgdown runs reference examples (run_dont_run = TRUE) before building vignettes, the cmdstanr.Rmd vignette then reused that threaded executable and errored in $sample() because threads_per_chain was not set. Compile a tempdir copy instead so the shared executable is left unchanged. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The `$compile()` example recompiles the CmdStan example model `examples/bernoulli/bernoulli` with `stan_threads = TRUE`. Because pkgdown runs reference examples (`run_dont_run = TRUE`) before building vignettes, the `cmdstanr.Rmd` vignette then reused that threaded executable and errored in `$sample()`: > The model executable was built with threading enabled but > 'threads_per_chain' was not set! This was always happening, but before #1212 the threading metadata went undetected due to the case-sensitivity bug, so sampling silently proceeded.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1219 +/- ##
==========================================
+ Coverage 91.76% 91.84% +0.08%
==========================================
Files 15 15
Lines 6252 6244 -8
==========================================
- Hits 5737 5735 -2
+ Misses 515 509 -6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submission Checklist
Summary
The
$compile()example recompiles the CmdStan example model withstan_threads = TRUE. Because pkgdown before building vignettes, thecmdstanr.Rmdvignette then reused that threaded executable and errored when trying to run sampling.This was always happening, but before #1212 the threading metadata went undetected due to the case-sensitivity bug.
Copyright and Licensing
Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Jonah
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses: