Skip to content

Chore: update example deps for ios#220

Draft
SbsCruz wants to merge 11 commits into
integration-ios-android-example-updatefrom
chore/update-example-deps
Draft

Chore: update example deps for ios#220
SbsCruz wants to merge 11 commits into
integration-ios-android-example-updatefrom
chore/update-example-deps

Conversation

@SbsCruz

@SbsCruz SbsCruz commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

This PR updates the dependencies in the example app to resolve compatibility issues with current React Native versions and cleans up environment configurations to fix build errors on ios.

Changes:

  • Updated dependencies in example/package.json.
  • Regenerated yarn.lock for consistency.
  • Updated App to use new RN components

@SbsCruz SbsCruz marked this pull request as draft June 17, 2026 15:10
@SbsCruz SbsCruz force-pushed the chore/update-example-deps branch from f4abe93 to 5f8984e Compare June 22, 2026 20:54
Comment thread example/index.js Outdated
<SafeAreaProvider>
<App />
</SafeAreaProvider>
));

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SbsCruz ❓ Why do we only include the Provider? I don't see we're using the hooks or other wrappers like SafeAreaView. Is the plan to use those later?

@SbsCruz SbsCruz Jul 3, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are including both, Provider as recommended here and SafeAreaView is used here

const updateSpot = useCallback((): void => {
const indexes = typeof index === "number" ? [index] : index;

// eslint-disable-next-line sonarjs/argument-type

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SbsCruz ❓ 🔧 Why do we need to disable sonarjs? Can we try to resolve the issues instead of ignoring them?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are currently working on solving this, thanks!

Comment thread package/package.json
"docs": "typedoc",
"release": "semantic-release",
"test": "vitest"
"test": "NODE_OPTIONS=\"--no-experimental-detect-module\" vitest"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SbsCruz ❓ Why do we want to enforce this?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Node attempted to guess whether a .js file is an ES Module (ESM) or CommonJS (CJS) by parsing its syntax, causing lines like:

import type ...

to throw an error since it was expecting a from instead of type
we are now looking to move this flags to vitest config so it's not on the package.json

@mateopozor02 mateopozor02 changed the base branch from main to integration-ios-android-example-update July 3, 2026 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants