Chore: update example deps for ios#220
Conversation
f4abe93 to
5f8984e
Compare
| <SafeAreaProvider> | ||
| <App /> | ||
| </SafeAreaProvider> | ||
| )); |
There was a problem hiding this comment.
@SbsCruz ❓ Why do we only include the Provider? I don't see we're using the hooks or other wrappers like SafeAreaView. Is the plan to use those later?
| const updateSpot = useCallback((): void => { | ||
| const indexes = typeof index === "number" ? [index] : index; | ||
|
|
||
| // eslint-disable-next-line sonarjs/argument-type |
There was a problem hiding this comment.
@SbsCruz ❓ 🔧 Why do we need to disable sonarjs? Can we try to resolve the issues instead of ignoring them?
There was a problem hiding this comment.
we are currently working on solving this, thanks!
| "docs": "typedoc", | ||
| "release": "semantic-release", | ||
| "test": "vitest" | ||
| "test": "NODE_OPTIONS=\"--no-experimental-detect-module\" vitest" |
There was a problem hiding this comment.
@SbsCruz ❓ Why do we want to enforce this?
There was a problem hiding this comment.
Node attempted to guess whether a .js file is an ES Module (ESM) or CommonJS (CJS) by parsing its syntax, causing lines like:
import type ...to throw an error since it was expecting a from instead of type
we are now looking to move this flags to vitest config so it's not on the package.json
This PR updates the dependencies in the
exampleapp to resolve compatibility issues with current React Native versions and cleans up environment configurations to fix build errors onios.Changes:
example/package.json.yarn.lockfor consistency.Appto use new RN components