Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#138 Again
It should be noticed that, when built with cargo 1.86 and
--releaseflag, this fix does provide performance gain (450Mbps -> 700Mbps) on a rattan link with no cells. Here are the flamegraphs:Current main, 1.86
This fix, 1.86
Yet when compiled with cargo 1.89, which is the latest stable version of cargo, there is no difference in neither performance (~800Mbps, yet on another machine) nor flame graph:
Current main, 1.89
This fix, 1.89
It seems that cargo 1.89 can optimize out the redundant
memsetthat this fix manually handles.