Repository navigation
fix(runtime): main lints and typechecks again after #32018 - #32168
Conversation
…and main typechecks again #32018 pushed headless-terminal-tab-close.ts over the 300-line lint limit, and its new test passed sleepWorktree to RuntimeNotifier after #31564 removed it. setMobileSessionTabProps moves unchanged into RuntimeHeadlessTabProperties, which already owns the helpers it calls and directly extends the close class.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Priority: ➖ Normal Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Description check |  |
The description explains the lint and typecheck failures, the code changes, and the reported test results. However, it omits most required template sections, including ELI5, Linked Issue, Visual Proof… | Complete the required template sections. Add an actual linked issue under “Linked Issue” using Fixes #... or the applicable issue reference. Add N/A with a reason under “Visual Proof” if there is no visual or interaction change. Complet… |
-
Check name Status Explanation Title check The title clearly and concisely describes the main change: restoring lint and typecheck success after #32018.Docstring Coverage Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
Full details: Description check
-
Explanation
The description explains the lint and typecheck failures, the code changes, and the reported test results. However, it omits most required template sections, including ELI5, Linked Issue, Visual Proof, structured Testing checkboxes, AI Disclosure, Review, Notes, and Checklist.
Resolution
Complete the required template sections. Add an actual linked issue under “Linked Issue” using
Fixes #...or the applicable issue reference. AddN/Awith a reason under “Visual Proof” if there is no visual or interaction change. Complete the Testing section and checklist, including the automated commands and known failures. Add the required compatibility, security, performance, and review notes.
✨ Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Main has been red since #32018. Every PR's static analysis job fails on main's code.
headless-terminal-tab-close.tswent over the 300-line lint limit (301).setMobileSessionTabPropsnow lives unchanged inRuntimeHeadlessTabProperties. That class already owns the tab-property helpers the method calls and directly extends the close class, so nothing in the class chain changes. The two abstract declarations that existed only for this method are gone.renderer-owned-tab-properties.test.ts(added in fix(runtime): reject unsupported renderer-owned tab properties #32018) passedsleepWorktreetoRuntimeNotifier, which feat(sidebar): main runs workspace sleep; the window follows (P3b) #31564 removed, sotc:nodefailed. The stale mock line is removed.Checks:
pnpm tc:nodeis clean. oxlint is clean on the touched files. Therenderer-owned-tab-propertiesandsession-tabstests pass, apart from twoheadless-browser-group-persistencetests andsession-tabs-empty-worktree-publication.spec.ts, which fail the same way on unmodified main.