Repository navigation
fix(native-chat): a dot between the queue header's label and its count - #29268
Conversation
The queue file sat at the 400-line cap, so the header dot had no room.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 2 minutes. View limit details
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Title check |  |
The title clearly and concisely describes the main change: adding a separator dot between the native chat queue header label and count. |
| Description check | |
The description is complete and aligned with the template. It explains the user-visible change, mechanism, rationale, linked issue, visual proof, testing, accessibility behavior, scope, and checklist … |
| Docstring Coverage | |
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 4 files. |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
✨ Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
ELI5
The small header above queued messages read "Paused2" or "Queued1": the word and the number ran together. It now reads "Paused · 2" and "Queued · 1", with a faint dot between them, on the desktop app and the phone.
What Changed
Before: the queue header showed the label and the count with only a 4px gap on desktop, so "Paused 2" read as "Paused2".
After: a middle dot sits between them: "Paused · 2" while the queue is held after Stop, "Queued · 2" while the agent works. The dot uses the count's muted colour and size. Nothing else in the header changes (Clear all, Resume, the fold chevron, the error caption).
Mechanism: the desktop header (
NativeChatQueuedMessageList.tsx) gets<span aria-hidden>·</span>between the label and the count, the same separator the queued-message editor already uses for "Editing message · sender". The phone header (MobileNativeChatQueuedMessages.tsx) gets a muted·text between its label and count, hidden from screen readers the way the phone's background-task rows hide their decorative meta text. Screen readers keep reading "Paused 2", not "Paused dot 2".The phone file was already exactly at the 400-line lint limit, so the queued card's expanding text (
MobileQueuedCardText) moves unchanged into its own file,MobileQueuedCardText.tsx, to make room. No behaviour change there.Why
Brennan's feedback on #28654: "Paused2 is too close together". A dot separator is the pattern Orca already uses for label-and-detail pairs in chat (background tasks, tool runs, the queue editor), so this reuses it rather than widening the gap or adding a new element.
Linked Issue
Follow-up to #28654.
Visual Proof
Rendered on a hidden, isolated test copy of Orca on the M4Air (own throwaway home, stand-in Codex agent, never the real one), driven over CDP by a QA driver. "Before" is the same running app with only
NativeChatQueuedMessageList.tsxswapped back to main's version.Whole window, paused:
Measured in the rendered page: the dot is its own element with
aria-hidden="true", 12px, colourrgb(161,161,161)(the count's muted colour). When paused, the label turns white and the dot and count stay muted.The phone header was not rendered (no development client in this check); its change is covered by the unchanged phone tests, which read only what a screen reader gets.
Testing
Desktop tests that pinned the header text (
NativeChatQueuedMessageList.test.tsx) now expect "Paused·2…" / "Queued·1". The phone tests read only screen-reader-visible text, so they are unchanged and confirm the dot stays hidden from screen readers.Rendered check on macOS (M4Air): see Visual Proof. Phone: not rendered.
I manually tested these changes locally
Automated tests added/updated, or explained why not below
Review
Agent skill upstream boundary
Notes
Presentation only: no wire, saved-data, SSH or platform-specific change.
Author: Brennan Benson (X: @BrennanKB5)
Checklist
N/Awith reasonpnpm lint,pnpm typecheck,pnpm test, andpnpm buildpass (or CI will cover; local preferred)