Repository navigation
revert(runtime): temporarily restore the previous host Node minimum - #26823
Merged
Merged
Conversation
This reverts commit 46460d4 (#26171). Pause the Node 24 requirement so existing SSH and WSL users are not surprised by a host-runtime upgrade requirement in the next release. This is a precautionary rollout hold requested to avoid near-term user disruption, not a cancellation of the Node 24 transition. Restore the prior Node 18 host minimum and companion build targets. The previously shipped bundled Node 24 runtime and compatibility launcher remain in place. Preserve the original change in a separate draft PR for reintroduction after compatibility and rollout validation.
6 of 14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ELI5
Temporarily put the host Node requirement back where it was before #26171, so existing SSH and WSL users are not surprised by an upgrade requirement in the next release.
What Changed
Reverts #26171: host discovery and server checks again accept the previous Node 18 minimum, companion builds target Node 18, and tests, CI and installation guidance return to that policy. The bundled runtime was already Node 24 before #26171 and keeps its existing pin and default. This does not revert the compatibility launcher or newer changes on main.
Why
This is a precautionary rollout pause requested to avoid near-term user disruption. The Node 24 transition remains planned and will be preserved in a separate draft PR. Raising the minimum again should wait for an explicit review of existing host configurations, fallback behavior and rollout communication.
A targeted revert is preferable to downgrading the bundled runtime, which other shipped functionality already uses, or hurriedly adding new fallback behavior.
Linked Issue
N/A — maintainer-requested rollback. Reverts #26171.
Visual Proof
N/A — runtime compatibility and build policy; no UI layout or interaction changes.
Testing
Verified locally on macOS arm64:
pnpm tc, staged lint/format checks andpnpm run check:code-quality:changedpassed.pnpm build:relayandpnpm build:orcadpassed.Cross-platform PR CI is still running. This precautionary rollback restores the previously accepted host policy; the restoration remains a draft pending fresh rollout validation.
Review
Reviewed the revert against the original merge commit and current main. Unrelated status-persistence work is preserved in its original worktree.
Agent skill upstream boundary
Notes
The restoration is preserved in draft PR #26824. No remote wire or persistence format changes.
Checklist
N/Awith reasonpnpm lint,pnpm typecheck,pnpm test, andpnpm buildpass (or CI will cover; local preferred)