Skip to content

revert(runtime): temporarily restore the previous host Node minimum - #26823

Merged
nwparker merged 1 commit into
mainfrom
nwparker/temporary-node24-rollback
Oct 9, 2026
Merged

nwparker merged 1 commit into
mainfrom
nwparker/temporary-node24-rollback

Conversation

@nwparker

@nwparker nwparker commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor
Files Added Deleted Net
Test 24 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​133 $\color{#cf222e}{\Huge{\mathbf{−}}}$​197 $\color{#cf222e}{\Huge{\mathbf{−}}}$​64
Prod 37 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​115 $\color{#cf222e}{\Huge{\mathbf{−}}}$​100 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​15

ELI5

Temporarily put the host Node requirement back where it was before #26171, so existing SSH and WSL users are not surprised by an upgrade requirement in the next release.

What Changed

Reverts #26171: host discovery and server checks again accept the previous Node 18 minimum, companion builds target Node 18, and tests, CI and installation guidance return to that policy. The bundled runtime was already Node 24 before #26171 and keeps its existing pin and default. This does not revert the compatibility launcher or newer changes on main.

Why

This is a precautionary rollout pause requested to avoid near-term user disruption. The Node 24 transition remains planned and will be preserved in a separate draft PR. Raising the minimum again should wait for an explicit review of existing host configurations, fallback behavior and rollout communication.

A targeted revert is preferable to downgrading the bundled runtime, which other shipped functionality already uses, or hurriedly adding new fallback behavior.

Linked Issue

N/A — maintainer-requested rollback. Reverts #26171.

Visual Proof

N/A — runtime compatibility and build policy; no UI layout or interaction changes.

Testing

  • I manually tested these changes locally
  • Automated tests added/updated, or explained why not below

Verified locally on macOS arm64:

  • Focused SSH, WSL, runtime and CI-policy tests: 505 distinct tests passed. One test for rejecting Node older than 18 is intentionally skipped when the launcher runs on Node 18.
  • pnpm tc, staged lint/format checks and pnpm run check:code-quality:changed passed.
  • pnpm build:relay and pnpm build:orcad passed.
  • All six managed-hook bundles loaded under real Node 18.20.8 and installed hooks in an isolated temporary home.
  • The compatibility launcher ran under real Node 18.20.8, handed off to bundled Node 24.21.0, preserved arguments and rejected altered server bytes.

Cross-platform PR CI is still running. This precautionary rollback restores the previously accepted host policy; the restoration remains a draft pending fresh rollout validation.

Review

Reviewed the revert against the original merge commit and current main. Unrelated status-persistence work is preserved in its original worktree.

Agent skill upstream boundary

  • Not applicable, or this change copies or mechanically translates no upstream skill-installer source, tests, fixtures, registry entries, path tables, comments, or documentation.

Notes

The restoration is preserved in draft PR #26824. No remote wire or persistence format changes.

Checklist

  • This PR is small and focused
  • I explained what changed and why (ELI5, the user-facing before/after, the mechanism, and why over the alternatives)
  • Before/after screenshots or videos attached for UI changes, or N/A with reason
  • Self-reviewed for correctness, security, and performance
  • Cross-platform, SSH/remote, and path/shortcut impact considered (or N/A)
  • pnpm lint, pnpm typecheck, pnpm test, and pnpm build pass (or CI will cover; local preferred)

This reverts commit 46460d4 (#26171).

Pause the Node 24 requirement so existing SSH and WSL users are not
surprised by a host-runtime upgrade requirement in the next release.
This is a precautionary rollout hold requested to avoid near-term user
disruption, not a cancellation of the Node 24 transition.

Restore the prior Node 18 host minimum and companion build targets.
The previously shipped bundled Node 24 runtime and compatibility launcher
remain in place. Preserve the original change in a separate draft PR for
reintroduction after compatibility and rollout validation.
@nwparker
nwparker merged commit 1578716 into main Oct 9, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant