Repository navigation
test(native-chat): fix main typecheck after the batched journal commit - #26781
Merged
Merged
Conversation
7 of 9 tasks
brennanb2025
marked this pull request as ready for review
October 9, 2026 07:44
8 tasks done
This was referenced Oct 9, 2026
This was referenced Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ELI5
Main doesn't typecheck right now. Two pull requests that were each green on their own merged into a combination that doesn't compile. This one-line test change makes main compile again.
What Changed
src/main/native-chat/agent-session-journal/command-receipt-transaction.test.ts:107:Argument of type 'readonly JournalRow[]' is not assignable to parameter of type 'JournalRow'.commitcallback to receive the batch of rows it committed. feat(native-chat): add a chat-owned command receipt store #26653 added this test, whose fakecommitstill took one row. Both passed CI against their own bases.commitnow takes the batch,commit: (rows) => committed.push(...rows), the same way fix(native-chat): settle a dead agent's leftover work in one write that always fits #26664 updatedjournal-row-writer.test.ts. No product code changes, and users see no difference.Why
It's a test-only fix to the test that didn't follow the writer's new signature. The product code from both PRs is already consistent.
Linked Issue
None (main hygiene). Follows #26653 and #26664.
Visual Proof
N/A: test-only change, nothing user-visible.
Testing
On origin/main cc2ad7b plus this change:
tsc -p config/tsconfig.node.json) passes;command-receipt-transaction.test.tspasses, 7/7.AI Disclosure
Review
Agent skill upstream boundary
Notes
Author: @BrennanKB5. Test-only. No security, platform, SSH, mobile or compatibility impact.
Checklist
N/Awith reasonpnpm lint,pnpm typecheck,pnpm test, andpnpm buildpass (or CI will cover; local preferred)