Skip to content

test(native-chat): fix main typecheck after the batched journal commit - #26781

Merged
brennanb2025 merged 1 commit into
mainfrom
brennanb2025/main-typecheck-batched-commit
Oct 9, 2026
Merged

brennanb2025 merged 1 commit into
mainfrom
brennanb2025/main-typecheck-batched-commit

Conversation

@brennanb2025

@brennanb2025 brennanb2025 commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor
Files Added Deleted Net
Test 1 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​1 $\color{#cf222e}{\Huge{\mathbf{−}}}$​1 0
Prod 0 0 0 0

ELI5

Main doesn't typecheck right now. Two pull requests that were each green on their own merged into a combination that doesn't compile. This one-line test change makes main compile again.

What Changed

Why

It's a test-only fix to the test that didn't follow the writer's new signature. The product code from both PRs is already consistent.

Linked Issue

None (main hygiene). Follows #26653 and #26664.

Visual Proof

N/A: test-only change, nothing user-visible.

Testing

  • I manually tested these changes locally
  • Automated tests added/updated, or explained why not below

On origin/main cc2ad7b plus this change:

  • the node typecheck (tsc -p config/tsconfig.node.json) passes;
  • command-receipt-transaction.test.ts passes, 7/7.

AI Disclosure

Review

Agent skill upstream boundary

  • Not applicable, or this change copies or mechanically translates no upstream skill-installer source, tests, fixtures, registry entries, path tables, comments, or documentation.

Notes

Author: @BrennanKB5. Test-only. No security, platform, SSH, mobile or compatibility impact.

Checklist

  • This PR is small and focused
  • I explained what changed and why (ELI5, the user-facing before/after, the mechanism, and why over the alternatives)
  • Before/after screenshots or videos attached for UI changes, or N/A with reason
  • Self-reviewed for correctness, security, and performance
  • Cross-platform, SSH/remote, and path/shortcut impact considered (or N/A)
  • pnpm lint, pnpm typecheck, pnpm test, and pnpm build pass (or CI will cover; local preferred)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant