Repository navigation
[CI] Reset the canonical PR stack cache in GraphQL test fixtures - #26346
Merged
Merged
Conversation
nwparker
changed the base branch from
nwparker/structured-surface-manifest-line-limit
to
main
October 7, 2026 23:20
nwparker
force-pushed
the
nwparker/github-fixture-stack-cache-reset
branch
from
October 7, 2026 23:20
01b94d6 to
9538edd
Compare
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthrough
Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to This test-fixture change clears cached PR-stack summaries. The relevant tests await these lookups and do not run them concurrently, so no actionable merge blocker is established. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
8 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ELI5
A GitHub test can fail depending on which earlier tests filled the pull-request stack cache. Clear that existing cache with the other caches when setting up the GraphQL rate-limit fixtures.
What Changed
Add the already-imported
_resetPRStackSummaryCacheForTests()call toresetGraphQLRateLimitGuardMocks. The canonical reset clears the stack-summary cache and pending lookups. Existing mock queues, production code, imports, tests, assertions and runtime routing remain the same.Why
The raw traces in both Node and Bun show that a warm stack cache skips a REST request, shifting which queued mock result the next PR-view call consumes. Reuse the existing reset already used by the neighboring fixture setup. Changing mock responses or assertions would conceal the state leak.
Linked Issue
The incoming manifest lint repair #26342 is merged. This PR now targets main with only the existing cache-reset call.
Visual Proof
N/A — test setup only; no visual or interaction change.
Testing
Before/after correctness measurements from run 37692284347, all eight counted commands retained:
There are no skipped cases or unhandled errors. The failure is the existing unknown-merge-queue assertion after a GraphQL failure; its exact identity is retained and is the only permitted status change. Full file/case/status multisets, source fingerprints, routes, settings and natural process exit match. Root independently replayed the frozen collector and checked all eight raw reports against the actual green CI result.
These are measurements on frozen source
29ad785b1cd000b580ba3b3da87affb835a601adusing Vitest 5.0.3, four workers, isolation, the six stock setup files and filesystem module cache disabled. The current product harness has the same qualified before and after bytes; all checks passed on earlier product head01b94d6, including ten unit shards, relay integration, and Linux/Windows package checks. It is now normally rebased onto merged main7abd74e8187d39cbdc8ff127969c5cd384a2a20b, head9538edd6fff193868f5909d54300a9811feebadb; only the qualified harness changes. Fresh changed-code checks and Node typecheck pass. Fresh current-head CI 37701762819 also passed: all ten unit shards, static analysis/typecheck, relay integration, Linux/Windows package checks and selection evidence. All 35 checks completed, with 19 passes and 16 explicit skips; no failures. This fixture correctness improvement makes no speed, import-optimization or production reliability claim. No native integration suite was launched on the user's desktop.Review
The canonical owner and reset behavior were independently reviewed. Full current-head CI passed. There are no unresolved review threads or actionable findings; independent canonical-reset and raw-data reviews passed. No new bot coverage is assumed.
Agent skill upstream boundary
Notes
No production host, remote GitHub/GitLab execution, workspace ownership, protocol or platform behavior changes.
Checklist
Pre-merge main is
de4ee59cba964d45489a2fbc3ab1a2f7937557aa. Later upstream work, including #26350, #25845, #26334 and the measured Radix imports #26256, is retained. The incoming harness still exactly matches its qualified before bytes. Current-head CI above does not claim coverage of those extra upstream commits as a combined tree.Merged squash
1f790332303926ef8bbec86006dc12ee8654865dhas actual parentde4ee59cba964d45489a2fbc3ab1a2f7937557aa. Root verifies that only the qualified harness changed and all before/after bytes match. Later upstream commits are retained; prior qualified-head CI does not claim coverage of those extra commits as a combined tree.